Support deserialising Word (and Word8 etc.) from PersistDouble#1491
Closed
isomorpheme wants to merge 2 commits intoyesodweb:masterfrom
Closed
Support deserialising Word (and Word8 etc.) from PersistDouble#1491isomorpheme wants to merge 2 commits intoyesodweb:masterfrom
isomorpheme wants to merge 2 commits intoyesodweb:masterfrom
Conversation
Contributor
Author
|
I'm not planning on working on this anymore so I'm closing this PR, but if anyone else wants to pick it back up then I'm happy to answer questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements approach no. 2 as discussed in #831. Just after authoring this I noticed that there's also PR #1096 which seems to do something more like approach no. 3, and it would conflict with this PR (e.g. it's stricter about deserialising PersistDoubles), though it looks like it's stalled for now.
Closes: #831
Before submitting your PR, check that you've:
AddedI'd like to add these to the relevant instances documenting the change in behaviour, but it looks like Haddock doesn't support adding a comment or the like.@sincedeclarations to the Haddockstylish-haskellon any changed files..editorconfigfile for details)After submitting your PR:
(unreleased)on the Changelog